Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FrontDoor WAF API to 2019-03-01-preview #5556

Merged
merged 6 commits into from
Mar 25, 2019

Conversation

eschwabe
Copy link
Contributor

  • Generated new SDK from swagger
  • Updated unit tests to use new swagger definition
  • Incremented Microsoft.Azure.Management.FrontDoor package version

This PR supersedes the automated PR 5527.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use generate.ps1 to generate the code and commit all changes

@@ -7,7 +7,7 @@
<PackageId>Microsoft.Azure.Management.FrontDoor</PackageId>
<Description>Provides management capabilities for Front Door services.</Description>
<AssemblyName>Microsoft.Azure.Management.FrontDoor</AssemblyName>
<Version>0.11.0-preview</Version>
<Version>0.12.0-preview</Version>
<PackageTags>Microsoft Azure Front Door management;FrontDoor;Front Door management;</PackageTags>
<PackageReleaseNotes>
Fixed a regression in enable/disable https for custom domain.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update packagereleasenotes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated release notes.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 0b205af into Azure:master Mar 25, 2019
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
* .NET SDK Resource Provider:'FrontDoor'
REST Spec PR 'Azure/azure-rest-api-specs#5437'
REST Spec PR Author 'eschwabe'
REST Spec PR Last commit

* .NET SDK Resource Provider:'FrontDoor'
REST Spec PR 'Azure/azure-rest-api-specs#5437'
REST Spec PR Author 'eschwabe'
REST Spec PR Last commit

* Fix unit tests to work with 2019-03-01-preview API

* Update package version

* Regenerate FrontDoor SDK and update unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants